Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: replace grpc.WithInsecure with insecure.NewCredentials #5177

Merged
merged 3 commits into from
Feb 9, 2022
Merged

cleanup: replace grpc.WithInsecure with insecure.NewCredentials #5177

merged 3 commits into from
Feb 9, 2022

Conversation

horizonzy
Copy link
Contributor

@horizonzy horizonzy commented Jan 28, 2022 •
edited by dfawley
Loading

RELEASE NOTES: n/a

@dfawley dfawley added the Type: Internal Cleanup Refactors, etc label Feb 1, 2022
@dfawley dfawley added this to the 1.45 Release milestone Feb 1, 2022
@dfawley dfawley requested a review from menghanl February 1, 2022 21:10
@menghanl menghanl changed the title replace grpc.WithInsecure usage. cleanup: replace grpc.WithInsecure with insecure.NewCredentials Feb 2, 2022
@easwars
Copy link
Contributor

easwars commented Feb 9, 2022

@horizonzy
Could you please rebase your branch with master. We had some flaky tests which we recently fixed. Getting those changes will make the tests on this PR green. Thanks.

@easwars easwars assigned horizonzy and unassigned menghanl Feb 9, 2022
@dfawley dfawley merged commit c44f627 into grpc:master Feb 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@menghanl menghanl menghanl approved these changes

Assignees

@horizonzy horizonzy

Labels
Status: Requires Reporter Clarification Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.45 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@horizonzy @easwars @menghanl @dfawley